[U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver
Mike Frysinger
vapier at gentoo.org
Sat Oct 8 23:17:05 CEST 2011
On Saturday 08 October 2011 15:21:02 Marek Vasut wrote:
> On Saturday, October 08, 2011 09:05:59 PM Mike Frysinger wrote:
> > On Friday 07 October 2011 08:30:55 Marek Vasut wrote:
> > > +#define LEFT_CNTR (1 << 0)
> > > +#define LEFT_SHIFT (1 << 1)
> > > +#define LEFT_ALT (1 << 2)
> > > +#define LEFT_GUI (1 << 3)
> > > +#define RIGHT_CNTR (1 << 4)
> > > +#define RIGHT_SHIFT (1 << 5)
> > > +#define RIGHT_ALT (1 << 6)
> > > +#define RIGHT_GUI (1 << 7)
> > > +
> > > +/* Size of the keyboard buffer */
> > > +#define USB_KBD_BUFFER_LEN 0x20
> > > +
> > > +/* Device name */
> > > +#define DEVNAME "usbkbd"
> >
> > #define<space> not #define<tab>
>
> Why?
there's nothing for you to align the define name to, and imo, looks wrong when
viewing the diff. looking at the source, "#define" is 7 chars, so the tab is
just a single char, but a diff throws that off turning it into 8 chars. and
it's pretty non-standard with the rest of the code base.
-MIKE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111008/771d298a/attachment.pgp
More information about the U-Boot
mailing list