[U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

Mike Frysinger vapier at gentoo.org
Sat Oct 8 23:18:28 CEST 2011


On Saturday 08 October 2011 15:21:17 Marek Vasut wrote:
> On Saturday, October 08, 2011 09:06:30 PM Mike Frysinger wrote:
> > On Friday 07 October 2011 16:10:11 Marek Vasut wrote:
> > > On Friday, October 07, 2011 07:38:19 PM Mike Frysinger wrote:
> > > > On Friday 07 October 2011 08:30:55 Marek Vasut wrote:
> > > > > Also, fix usb drivers which use extern new.
> > > > 
> > > > this summary/changelog is lacking in information as to what you
> > > > actually did and why ...
> > > 
> > > Hi Mike, generally shuffling with code, abstracting out some things,
> > > making it checkpatch-comformant. Also, addition of generic key report
> > > code when polling.
> > 
> > it's hard to evaluate each piece by itself when it's just one patch
> > smooshing it all together
> 
> Well how would you rework crap code piece by piece?

- fix style
- abstract out stuff
- add new generic key support

i'm not the usb maintainer, so if Remy is fine with the work as he can follow 
it, then that's fine.  i'm not terribly familiar with internal usb code, so 
it's hard to pick out what's going on.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111008/cccafba5/attachment.pgp 


More information about the U-Boot mailing list