[U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

[Marek Vasut]

On Sunday, October 09, 2011 11:01:36 AM Remy Bohmer wrote:
> Hi Marek,
> 
> >> > > it's hard to evaluate each piece by itself when it's just one patch
> >> > > smooshing it all together
> >> > 
> >> > Well how would you rework crap code piece by piece?
> >> 
> >> - fix style
> >> - abstract out stuff
> > 
> > Not like there was so much abstraction it couldn't be squashed into this
> > one.
> > 
> >> - add new generic key support
> > 
> > True, this could be separated out. Well, Remy ... what do you think?
> 
> A patch that fixes style issues should _only_ fix style issues. It
> should not contain any functional change. This makes it all easier to
> review. Not only for me, but for everyone else as well.

That I understand, but I started the rework with properly passing the keyboard 
data in mind. That got me to a point where I had to change most of the code, 
including fixing some of the usb host drivers (because they used that extern 
new;). And from that point, it was pointless to try keeping it separate.

btw Mike, I was wrong, the generic key support can't be separated out, it must 
be there because you can't access the extern new anymore.

Cheers
> 
> Kind regards,
> 
> Remy