[U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver
Marek Vasut
marek.vasut at gmail.com
Sun Oct 9 21:12:17 CEST 2011
On Sunday, October 09, 2011 08:54:07 PM Wolfgang Denk wrote:
> Dear Marek Vasut,
>
> In message <1317990657-17214-2-git-send-email-marek.vasut at gmail.com> you
wrote:
> > Also, fix usb drivers which use extern new.
> >
> > Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> > Cc: Ajay Kumar Gupta <ajay.gupta at ti.com>
> > Cc: Bryan Wu <bryan.wu at analog.com>
> > Cc: Cliff Cai <cliff.cai at analog.com>
> > Cc: Mike Frysinger <vapier at gentoo.org>
> > Cc: Remy Bohmer <linux at bohmer.net>
> > Cc: Wolfgang Denk <wd at denx.de>
> > ---
> >
> > common/usb_kbd.c | 644
> > ++++++++++++++++++++++++------------------- drivers/usb/host/ehci-hcd.c
> > | 20 +--
> > drivers/usb/musb/musb_hcd.c | 19 +--
> > include/usb.h | 1 +
> > 4 files changed, 369 insertions(+), 315 deletions(-)
> >
> > NOTE: Tested on EfikaSB device, but please test on some more hardware
> > first!
> >
> > diff --git a/common/usb_kbd.c b/common/usb_kbd.c
> > index 503d175..d19551b 100644
> > --- a/common/usb_kbd.c
> > +++ b/common/usb_kbd.c
> > @@ -25,402 +25,490 @@
> >
> > *
> > */
> >
> > #include <common.h>
> >
> > +#include <malloc.h>
> >
> > #include <stdio_dev.h>
> > #include <asm/byteorder.h>
> >
> > #include <usb.h>
> >
> > -#undef USB_KBD_DEBUG
> > +/* USB Keyboard Debug */
> > +#undef USB_KBD_DEBUG
>
> Please do not undef what is not defined [or what a user might want to
> define on the command line].
Command line ? This is a placeholder in case the user wants to debug this piece
of code.
>
> > +/* Keyboard sampling rate */
> > +#define REPEAT_RATE (40 / 4) /* 40msec -> 25cps */
> > +#define REPEAT_DELAY 10 /* 10 x REAPEAT_RATE = 400msec
*/
>
> Please fix the typo while you are at it.
True.
>
> And please split code changes and pure cosmetic ones into separate
> commits. Thanks.
Well that means I can do all this work one more time :-( I'll get to it
sometimes ... later.
Cheers
>
> Best regards,
>
> Wolfgang Denk
More information about the U-Boot
mailing list