[U-Boot] [PATCH][V3] drivers: add the support for Silicon Image SATA controller

[Wolfgang Denk]

Dear Tang Yuantian-B29983,

In message <3C06C26914DACA4BB3A368F78CA0B3A70EA8F2 at 039-SN1MPN1-005.039d.mgd.msft.net> you wrote:
> 
> Did you say the following warnings:
> ---------
> WARNING: Use #include <linux/io.h> instead of <asm/io.h>
> #79: FILE: drivers/block/sata_sil.c:26:
> +#include <asm/io.h>

We should add this to a U-Boot specific ignore list.

> WARNING: externs should be avoided in .c files
> #90: FILE: drivers/block/sata_sil.c:37:
> +extern block_dev_desc_t sata_dev_desc[CONFIG_SYS_SATA_MAX_DEVICE];

This should be fixed.
> 
> The first warning can't be fixed because there is no <linux/io.h> in uboot.

Agreed.

> I left the second warning on purpose because other sata drivers do the same way.

Well, it would be better to fix the other drivers as well.

> I will fix the second warning.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is a human characteristic to love little  animals,  especially  if
they're attractive in some way.
	-- McCoy, "The Trouble with Tribbles", stardate 4525.6