[U-Boot] [PATCH v5 01/20] sandbox: Add architecture header files

[Mike Frysinger]

On Sunday 09 October 2011 15:28:16 Wolfgang Denk wrote:
> Simon Glass wrote:
> > 0 errors, 44 warnings for
> > 0001-sandbox-Add-architecture-header-files.patch: warning:
> > arch/sandbox/include/asm/bitops.h,30: Use of volatile is usually wrong:
> > see Documentation/volatile-considered-harmful.txt warning:
> > arch/sandbox/include/asm/bitops.h,32: Use of volatile is usually wrong:
> > see Documentation/volatile-considered-harmful.txt warning:
> > arch/sandbox/include/asm/bitops.h,34: Use of volatile is usually wrong:
> > see Documentation/volatile-considered-harmful.txt warning:
> > arch/sandbox/include/asm/bitops.h,36: Use of volatile is usually wrong:
> > see Documentation/volatile-considered-harmful.txt warning:
> > arch/sandbox/include/asm/bitops.h,44: Use of volatile is usually wrong:
> > see Documentation/volatile-considered-harmful.txt warning:
> > arch/sandbox/include/asm/bitops.h,54: Use of volatile is usually wrong:
> > see Documentation/volatile-considered-harmful.txt warning:
> > arch/sandbox/include/asm/bitops.h,66: Use of volatile is usually wrong:
> > see Documentation/volatile-considered-harmful.txt warning:
> > arch/sandbox/include/asm/bitops.h,76: Use of volatile is usually wrong:
> > see Documentation/volatile-considered-harmful.txt warning:
> > arch/sandbox/include/asm/bitops.h,88: Use of volatile is usually wrong:
> > see Documentation/volatile-considered-harmful.txt warning:
> > arch/sandbox/include/asm/bitops.h,90: Use of volatile is usually wrong:
> > see Documentation/volatile-considered-harmful.txt
> > 
> > (These are the bitops and seem to have volatile in all the other archs
> > also.)
> 
> Existence of bad code examples is no excuse for submitting new bad
> code.

maybe we should take this up with LKML rather than forcing our code to 
randomly fork ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111009/e7827351/attachment.pgp