[U-Boot] [PATCH] microblaze: Enable SERIAL_MULTI

Wolfgang Denk wd at denx.de
Mon Oct 10 14:57:28 CEST 2011


Dear Michal Simek,

In message <4E92CE64.5000609 at monstr.eu> you wrote:
>
> >>      defined(CONFIG_MB86R0x) || defined(CONFIG_MPC5xxx) || \
> >>      defined(CONFIG_MPC83xx) || defined(CONFIG_MPC85xx) || \
> >>      defined(CONFIG_MPC86xx) || defined(CONFIG_SYS_SC520) || \
> >> -    defined(CONFIG_TEGRA2)
> >> +    defined(CONFIG_TEGRA2) || defined(CONFIG_MICROBLAZE)
> > 
> > Am I the only one that thinks this is all really ugly?
> 
> I hope you mean serial.h not mb code.
> 
> I agree with you but not sure if we can remove all ifdefs there.

The long list of device specific ifdef's should be converted into a
single ifdef testing for a specific feature instead.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"He only drinks when he gets depressed." "Why does he get depressed?"
"Sometimes it's because he hasn't had a drink."
                                     - Terry Pratchett, _Men at Arms_


More information about the U-Boot mailing list