[U-Boot] WARNING: space prohibited between function name and open parenthesis '('
Wolfgang Denk
wd at denx.de
Mon Oct 10 22:36:04 CEST 2011
Dear Stephen Warren,
In message <74CDBE0F657A3D45AFBB94109FB122FF173B23B59F at HQMAIL01.nvidia.com> you wrote:
> I'm getting a lot of the following when running checkpatch:
>
> WARNING: space prohibited between function name and open parenthesis '('
>
> Should I ignore these?
No, these should be fixed.
> So far, I've written completely new code such that it doesn't trigger
> this warning, but where editing existing code (e.g. just changing the
> name of a function), I've avoided fixing this checkpatch warning so it's
> more obvious what my diff is doing; equally, fixing this would cause the
> lines I edit to be inconsistent with those around them.
>
> Any guidance appreciated. Thanks.
The normal procedure is to submit a [COSMETIC] patch first that fixes
the coding style issues of the affected file (and _only_ these), and
then submit a chackpatch-clean patch with the actual changes.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
EARTH
smog | bricks
AIR -- mud -- FIRE
soda water | tequila
WATER
More information about the U-Boot
mailing list