[U-Boot] [PATCH 1/2] AVR32: use generic mmc framework

[Andreas Bießmann]

Dear Sven,

Am 12.10.2011 15:09, schrieb Sven Schnelle:
> gen_atmel_mci works on AVR32 as well, so no need to use the legacy
> mmc driver. This also has the nice side effect of being able to use
> SDHC cards an AVR32 boards.
> 
> Signed-off-by: Sven Schnelle <svens at stackframe.org>

I have to NACK this patch cause it produces new compile warnings.

$ PATH=$AVR32_PATH:$PATH BUILD_DIR=/tmp/build_uboot BUILD_NCPU=8
./MAKEALL atstk1002
Configuring for atstk1002 board...
board.c: In function 'board_init_r':
board.c:338: warning: implicit declaration of function 'mmc_initialize'
atstk1000.c: In function 'board_mmc_init':
atstk1000.c:147: warning: implicit declaration of function 'atmel_mci_init'
   text	   data	    bss	    dec	    hex	filename
 106091	   7504	 211676	 325271	  4f697	/tmp/build_uboot/u-boot

--------------------- SUMMARY ----------------------------
Boards compiled: 1
Boards with warnings or errors: 1 ( atstk1002 )
----------------------------------------------------------

And does not work on device:

a) mmc init is not known? Is this not longer necessary?

---8<---
U-Boot> mmc init
Unknown command 'mmc' - try 'help'
U-Boot> mmc help
mmc - MMC sub system

Usage:
mmc read addr blk# cnt
mmc write addr blk# cnt
mmc erase blk# cnt
mmc rescan
mmc part - lists available partition on current mmc device
mmc dev [dev] [part] - show or set current mmc device [partition]
mmc list - lists available devices
U-Boot>
--->8---

b) ext2ls is not reliable:

---8<---
U-Boot> ext2ls mmc 0:1
<DIR>       1024 .
<DIR>       1024 ..
<DIR>      12288 lost+found
gen_atmel_mci: CMDR 00051051 (17) ARGR 02008600 (SR: 00400025) Data
Transfer Failed
 ** ext2fs_devread read error - last part
U-Boot>
--->8---

best regards

Andreas Bießmann