[U-Boot] [PATCH v3 2/4] tegra2: Move board_mmc_init into board files

Stephen Warren swarren at nvidia.com
Wed Oct 12 16:50:15 CEST 2011


Simon Glass wrote at Tuesday, October 11, 2011 5:46 PM:
> Hi Stephen,
> 
> On Thu, Oct 6, 2011 at 10:53 AM, Stephen Warren <swarren at nvidia.com> wrote:
> > For Seaboard, this is mostly a cut/paste of board_mmc_init() and
> > pin_mux_mmc() into seaboard.c; pin_mux_mmc() was modified to add some
> > missing pinmux_tristate_disable calls for the GPIOs.
> >
> > For Harmony, those functions were modified to configure SDMMC2 (index 2)
> > instead of SDMMC3 (index 1), since that's what is present on the board.
> >
> > However, harmony.c is still missing the required GPIO setup, so neither
> > port is likely to function correctly yet.  This will be fixed in the next
> > change.
> >
> > Signed-off-by: Stephen Warren <swarren at nvidia.com>
> 
> I get a warning - I think you need to include ../common/board.h in
> seaboard/harmony.c
> 
> seaboard.c:100:2: warning: implicit declaration of function
> 'tegra2_mmc_init' [-Wimplicit-function-declaration]
> 
> Other than that I tested it and it works fine.

Yes, I'd already fixed this locally for v4, but hadn't reposted yet
pending your comments; will do soon.

Thanks for testing.

-- 
nvpublic



More information about the U-Boot mailing list