[U-Boot] [PATCH v2] arm, logbuffer: make it compileclean

Mike Frysinger vapier at gentoo.org
Wed Oct 12 17:21:24 CEST 2011


On Wednesday 12 October 2011 07:13:38 Heiko Schocher wrote:
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
> @@ -80,7 +80,6 @@ extern void rtl8019_get_enetaddr (uchar * addr);
>  #include <i2c.h>
>  #endif
> 
> -
>  /************************************************************************
>   * Coloured LED functionality
>   ************************************************************************

this looks like useless noise that checkpatch doesn't even complain about

> --- a/common/cmd_log.c
> +++ b/common/cmd_log.c
> 
>  unsigned long __logbuffer_base(void)
>  {
> -	return CONFIG_SYS_SDRAM_BASE + gd->bd->bi_memsize - LOGBUFF_LEN;
> +	return CONFIG_SYS_SDRAM_BASE + gd->ram_size - LOGBUFF_LEN;
>  }

i'm guessing avr32/microblaze not having ram_size in their global_data is a 
bug ?  conversely, arm is the only arch that doesn't have bi_memsize in their 
board_data ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111012/bb21d3bd/attachment.pgp 


More information about the U-Boot mailing list