[U-Boot] [PATCH] AVR32: switch to generic mmc framework

Reinhard Meyer u-boot at emk-elektronik.de
Wed Oct 12 19:01:52 CEST 2011


Dear Sven Schnelle,
> Hi List,
>
> these patches switch all AVR32 boards to the generic MMC framework. Motivation
> for doing so is to be able to boot from SDHC cards. The second patch removes
> the legacy atmel_mci driver, as it is no longer used by any board.
>
> I've only tried this code on the Atmel ATNGW100, as i have no other AVR32 boards.
> Would be great if some other users could try that patch on different platforms.
>
> It seems like the gen_atmel_mci driver doesn't work with Multible Block transfer on
> AVR32, but the old code didn't used that mode either. So that's something for the TODO
> list for future improvements.

1. your patch title is misleading, because it also affects the AT91 architecture.
use AVR32 when patches affect avr32 only
use AT91 when patches affect at91 only
use ATMEL when patches affect generic Atmel stuff
2. you should use the git rename feature to rename files

As I see it, all this should come as three patches:

1. switching *all* AVR32 and AT91 boards to use the *existing* generic driver

2. removal of the now obsolete legacy driver

3. renaming the existing generic driver into the old legacy name
(this is a pure cosmetic act)

I would tend to dispute whether 3. is really necessary and beneficial

Best Regards
Reinhard


More information about the U-Boot mailing list