[U-Boot] [PATCH] tools: checkpatch.pl from Linux added to tools

[Mike Frysinger]

On Thursday 13 October 2011 13:25:51 Joe Hershberger wrote:
> On Wed, Oct 12, 2011 at 10:27 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> > On Tuesday 11 October 2011 21:41:19 Joe Hershberger wrote:
> >> --- /dev/null
> >> +++ b/.checkpatch.conf
> >> 
> >> +# Not Linux, so don't expect a Linux tree.
> >> +--no-tree
> 
> Why depend on or have to specify where a linux tree is for building u-boot?

that's not how it works.  use the u-boot tree as the "linux" tree.

> > the only things checkpatch.pl uses $tree for, i think we want.  like
> > #include asm/foo.h instead of linux/foo.h.  why do you want this ?
> > 
> >> +# For Linux includes
> >> +--ignore ARCH_INCLUDE_LINUX
> >> +--ignore INCLUDE_LINUX
> > 
> > i think these checks are good actually.  we import headers from Linux all
> > the time ...
> 
> These seem to be irrelevant if --no-tree is specified.  It doesn't
> seem like checkpatch would make good decisions about this anyway given
> that an include file that exists in the referred-to Linux tree may not
> exist in the u-boot tree.

use the u-boot tree, then it works fine
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111013/22988a30/attachment.pgp