[U-Boot] [PATCH] tools: checkpatch.pl from Linux added to tools

[Mike Frysinger]

On Thursday 13 October 2011 14:30:12 Joe Hershberger wrote:
> On Thu, Oct 13, 2011 at 1:20 PM, Mike Frysinger wrote:
> > On Thursday 13 October 2011 13:25:51 Joe Hershberger wrote:
> >> On Wed, Oct 12, 2011 at 10:27 PM, Mike Frysinger wrote:
> >> > On Tuesday 11 October 2011 21:41:19 Joe Hershberger wrote:
> >> >> +# For Linux includes
> >> >> +--ignore ARCH_INCLUDE_LINUX
> >> >> +--ignore INCLUDE_LINUX
> >> > 
> >> > i think these checks are good actually.  we import headers from Linux
> >> > all the time ...
> >> 
> >> These seem to be irrelevant if --no-tree is specified.  It doesn't
> >> seem like checkpatch would make good decisions about this anyway given
> >> that an include file that exists in the referred-to Linux tree may not
> >> exist in the u-boot tree.
> > 
> > use the u-boot tree, then it works fine
> 
> With the latest version of checkpatch that does not work...

sad

> checkpatch looks for the following files/folders to identify the
> top_of_kernel_tree:
> 
>                 "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
>                 "README", "Documentation", "arch", "include", "drivers",
>                 "fs", "init", "ipc", "kernel", "lib", "scripts",
> 
> u-boot has no Kbuild, Documentation, init, ipc, kernel, or scripts.

i guess let's talk to lkml to see about decoupling this so that only the 
required paths get checked for the relevant tests.  for the header tests, that 
should only require include/linux/ to exist.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111013/8fd38fd7/attachment.pgp