[U-Boot] [PATCH 4/6] davinci_emac: fix for running with dcache enabled

Anton Staaf robotboy at chromium.org
Thu Oct 13 22:19:45 CEST 2011


On Thu, Oct 13, 2011 at 1:03 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Anton Staaf,
>
> In message <CAF6FioWHpeA8_nPA85e3SPc17ZDCkzqkV2ROs_EAaB_9wV9vEA at mail.gmail.com> you wrote:
>>
>> Would you be OK with a build warning for the lack of definition of
>> CONFIG_SYS_CACHELINE_SIZE like I have now if it only happened
>> once per board? ...
>
> Yes, that would be great.

Turns out I was able to define ARCH_DMA_MINALIGN for all U-Boot
architectures and use that
instead of the actual cache line size to generate correctly aligned
buffers.  My latest
patch set implements this.  So we shouldn't have any warnings being
generated and we should
have no need for the extra file (or addition to main.c) to generate
said warnings.  :)

Thanks,
    Anton

>>              ... I could move it from common.h to a c file that is always
>> built.  Perhaps I could add a checks.c file to libgeneric?  I'm not really sure
>> if that's the right place for it.  Do you have a suggestion?
>
> I'd like to avoid a new file.  But I don't have a good idea either.
> Well, heck, go and add the test to the top of common/main.c .
>
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> What can it profit a man to gain the whole world and to come  to  his
> property with a gastric ulcer, a blown prostate, and bifocals?
>                                     -- John Steinbeck, _Cannery Row_
>


More information about the U-Boot mailing list