[U-Boot] Interrupt issue about bootvx command

[Wolfgang Denk]

Dear Peter Pan,

please stop top posting / full quoting.


In message <CAGQXtZFp6oE_BjQGd6SSDAYk7kkg4-dy_1==LNK2Snh5h1Gfmg at mail.gmail.com> you wrote:
> 
> And the following is my updated patch. My git does not have "git
> send-mail" supported, so I have to paste the formatted commit below.
> Sorry for that.

Well, you'd better spend the time installing a full-featured version
of git.

> From 9758bc34e8459c8b906029105e41fe8adf9e79ca Mon Sep 17 00:00:00 2001
> From: Ke Pan <pppeterpppan at gmail.com>
> Date: Thu, 13 Oct 2011 10:34:23 +0800
> Subject: [PATCH] common/cmd_elf : Disable interrupts before boot vxWorks
> 
> The vxWorks needs all interrupts to be disabled before its boot.

Hm... And what exactly was not clear about the following statement:

> > Checkpatch says: total: 2 errors, 3 warnings, 10 lines checked
> >
> > Please see http://www.denx.de/wiki/U-Boot/Patches ; then clean up and
> > resubmit.

- Your commit message is mixed with text that belongs to the comment
  section only.

- Your SoB line is still missing

- There is a typo in "Disableing"; actually you should get rid of this
  printf().



Are there any testers out there?  I don't want to take this untested,
and I don't have any VxWorks anywhere around... (nor any other
proprietary code :-)

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I'd rather be led to hell than managed to heaven.