[U-Boot] [PATCH 4/6] davinci_emac: fix for running with dcache enabled

[Anton Staaf]

On Thu, Oct 13, 2011 at 1:36 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Thursday 13 October 2011 16:03:37 Wolfgang Denk wrote:
>> Anton Staaf wrote:
>> >              ... I could move it from common.h to a c file that is always
>> >
>> > built.  Perhaps I could add a checks.c file to libgeneric?  I'm not
>> > really sure if that's the right place for it.  Do you have a suggestion?
>>
>> I'd like to avoid a new file.  But I don't have a good idea either.
>> Well, heck, go and add the test to the top of common/main.c .
>
> fwiw, we added a dummy file in the Blackfin linux port called "arch_checks.c"
> where we kept all of our #ifdef sanity checks.  that way it got checked once
> (rather than in every header include), and we didn't have to clutter up semi-
> related files with it.

This makes sense to me, as it is pretty much what I did initially.  I ended up
not sending that patch up because I was able to define ARCH_DMA_MINALIGN for
all architectures we care about.  But in the future it might be a good pattern
for static checking configs.

Thanks,
    Anton

> -mike
>