[U-Boot] [PATCH 6/8] AM35xx: add EMAC support

[Ilya Yanok]

Hi Mike,

On 14.10.2011 02:55, Mike Frysinger wrote:
>> --- /dev/null
>> +++ b/arch/arm/cpu/armv7/omap3/emac.c
>>
>> +/*
>> + * Initializes on-chip ethernet controllers.
>> + * to override, implement board_eth_init()
>> + */
>> +int cpu_eth_init(bd_t *bis)
>> +{
>> +	davinci_emac_initialize();
>> +
>> +	return 0;
>> +}
> 
> shouldn't emac support always be up to the board porter and not the SoC code ?  

It's up to the board porter to define CONFIG_DRIVER_TI_EMAC (or not),
isn't it enough?

> also, this should be:
> int cpu_eth_init(bd_t *bis)
> {
> 	return davinci_emac_initialize();
> }

Agreed.

Regards, Ilya.