[U-Boot] [RESEND PATCH v2] tegra2: Enable data cache

[Stephen Warren]

Tom Warren wrote at Friday, October 14, 2011 9:56 AM:
> Stephen Warren wrote at Friday, October 14, 2011 8:04 AM:
> > Simon Glass wrote at Thursday, October 13, 2011 6:18 PM:
> > > On Thu, Oct 13, 2011 at 5:06 PM, Tom Warren <TWarren at nvidia.com> wrote:
> > > > Simon Glass wrote at Wednesday, October 12, 2011 2:13 PM:
> > ...
> > > >> Yes that's right since yesterday's merge of MMC into u-boot-arm (prior
> > > >> to that there was no working MMC!). Let's hold off applying this patch
> > > >> until you are done.
> > > >>
> > > >
> > > > I have to disagree with the 'no working MMC' statement. When I submitted my Tegra2 MMC driver in
> > > > May, it was working fine on Seaboard (hadn't tested yet on Harmony since mine was dead). At that time,
> > > > DCACHE was off, so no concurrency issues nor hangs were seen. Wolfgang merged it w/master in mid-July.
> > > >
> > > > Just correcting for the record,
> > >
> > > Yes I suspect you are right, it could just be my Seaboard - I have a
> > > different one from what I was using a few months ago. With this new
> > > one I see:
> >
> > I think the issue is that MMC/SD work OK with Tom's patch "tegra2: Enable
> > MMC for Seaboard", which isn't yet merged into mainline U-Boot. Without
> > that, neither the MMC nor SD slot worked for me.
> 
> Not to quibble, but see commit 74fac70084bb040342fafc3b0d2ef50fbe35646f:
> 
> commit 74fac70084bb040342fafc3b0d2ef50fbe35646f
> Merge: 1bb5e90 8fd01b8
> Author: Wolfgang Denk <wd at denx.de>
> Date:   Tue Jul 19 22:27:07 2011 +0200
> 
>     Merge branch 'master' of git://git.denx.de/u-boot-mmc
...
> ->      mmc: Tegra2: Enable SD/MMC driver for Seaboard and Harmony
> ->      mmc: Tegra2: SD/MMC driver for Seaboard - eMMC on SDMMC4, SDIO on SDMMC3
> 
> It would appear that Wolfgang merged my changes into the master branch
> on July 19th, unless I'm misreading this. Note that I don't see any
> commit by me labeled "tegra2: Enable MMC for Seaboard" - I'm assuming
> you meant this one.

No, I meant the following:

http://patchwork.ozlabs.org/patch/115861/

This does at least two necessary things:

a) Drives the power GPIO for the SD slot, else it's turned off.

b) Adds MMC_MODE_HC to mmc->host_caps, without which the internal eMMC
didn't work for me.

-- 
nvpublic