[U-Boot] [PATCH 01/10] Add getenv_int() to read an integer from an environment variable

Wolfgang Denk wd at denx.de
Fri Oct 14 21:29:30 CEST 2011


Dear Simon Glass,

In message <1318552994-6653-2-git-send-email-sjg at chromium.org> you wrote:
>
> --- a/include/common.h
> +++ b/include/common.h
...
> +/**
> + * Decode the value of an environment variable and return it.
> + *
> + * @param name		Name of environemnt variable
> + * @param base		Number base to use (normally 10, or 16 for hex)
> + * @param default_val	Default value to return if the variable is not
> + *			found
> + * @return the decoded value, or default_val if not found
> + */

Please don't add such documentation to common.h (especially not when it
breaks the coding style for multiline comments).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Just Say No."   - Nancy Reagan
"No."            - Ronald Reagan


More information about the U-Boot mailing list