[U-Boot] [PATCH 1/2] fdt: Add new fdt_set_node_status & fdt_set_status_by_alias helpers

Jerry Van Baren gvb.uboot at gmail.com
Sat Oct 15 15:04:06 CEST 2011


Hi Kumar, Shengzhou,

On 10/14/2011 03:10 PM, Kumar Gala wrote:
> From: Shengzhou Liu<Shengzhou.Liu at freescale.com>
>
> Add common function fdt_set_node_status() to assist in various locations
> that we set a nodes status.  This function utilizes the status values
> that are part of the EPAPR spec (on power.org).
>
> fdt_set_status_by_alias() is based on fdt_set_node_status() but uses an
> alias string to identify the node to update.
>
> We also add some shortcut functions to help the common cases of setting
> "okay" and "disabled":
>
> 	fdt_status_okay()
> 	fdt_status_disabled()
> 	fdt_status_okay_by_alias()
> 	fdt_status_disabled_by_alias()
>
> Finally, we fixup the corenet_ds ethernet code which previously had
> a function by the same name that can be replaced with the new helpers.
>
> Signed-off-by: Shengzhou Liu<Shengzhou.Liu at freescale.com>
> Signed-off-by: Kumar Gala<galak at kernel.crashing.org>
> ---
>   board/freescale/corenet_ds/eth_hydra.c |   26 ++------------
>   board/freescale/corenet_ds/eth_p4080.c |   36 +++++--------------
>   common/fdt_support.c                   |   60 +++++++++++++++++++++++++++++++-
>   include/fdt_support.h                  |   28 +++++++++++++++
>   4 files changed, 101 insertions(+), 49 deletions(-)

While this touches fdt_support.[ch] which is nominally "mine", it is 
coupled with the Freescale support.  I could make you break it into two, 
but then I would have to do more work and you (and wd) would have to 
make sure they went into u-boot in the right order.  That sounds ugly, 
so I would prefer Kumar apply it to his subrepo to feed into u-boot.

Acked-by: Gerald Van Baren <vanbaren at cideas.com>

Best regards,
gvb

[snip]


More information about the U-Boot mailing list