[U-Boot] [PATCH v3] NS16550: buffer reads

[Simon Glass]

Hi Marek,

On Sat, Oct 15, 2011 at 9:18 PM, Marek Vasut <marek.vasut at gmail.com> wrote:
> On Sunday, October 16, 2011 05:56:56 AM Simon Glass wrote:
>> Hi Marek,
>>
>> On Sat, Oct 15, 2011 at 10:55 AM, Marek Vasut <marek.vasut at gmail.com> wrote:
>> > On Saturday, October 15, 2011 06:03:52 PM Simon Glass wrote:
>> >> From: Scott Wood <scottwood at freescale.com>
>> >>
>> >> From: Scott Wood <scottwood at freescale.com>
>> >>
>> >> This improves the performance of U-Boot when accepting rapid input,
>> >> such as pasting a sequence of commands.
>> >
>> > Hi Simon,
>> >
>> > [...]
>> >
>> >> diff --git a/include/ns16550.h b/include/ns16550.h
>> >> index 51f1c17..60b0abc 100644
>> >> --- a/include/ns16550.h
>> >> +++ b/include/ns16550.h
>> >> @@ -164,6 +164,6 @@ typedef volatile struct NS16550 *NS16550_t;
>> >>
>> >>  void NS16550_init   (NS16550_t com_port, int baud_divisor);
>> >>  void NS16550_putc   (NS16550_t com_port, char c);
>> >> -char NS16550_getc   (NS16550_t com_port);
>> >> -int  NS16550_tstc   (NS16550_t com_port);
>> >> +char NS16550_getc(NS16550_t regs, unsigned int port);
>> >> +int NS16550_tstc(NS16550_t regs, unsigned int port);
>> >>  void NS16550_reinit (NS16550_t com_port, int baud_divisor);
>> >
>> > Maybe you should fix the indent altogether ?
>>
>> I should probably do a separate patch for that.
>
> Maybe queue it before this one ? :) Thanks!

OK I will add a new patch before the main one which cleans up the
warnings in the file.

Regards,
Simon

>
>>
>> Regards,
>> Simon
>>
>> > Cheers
>