[U-Boot] [PATCH v2 1/2] Introduce generic TPM support in u-boot

[Wolfgang Denk]

Dear Vadim Bendebury,

In message <CANy1bu+DZmD_Z=AU8LdTUy7ewHfwMU-8PvH1OA1jba9Tz1xuxA at mail.gmail.com> you wrote:
>
> >> I am not sure what is wrong with a short macro in this case - is this
> >> against the coding style?
> >
> > It doesn't do typechecking.
> 
> but the code around it does, doesn't it?

I explained this yesterday, too.  Functions are preferred over macros.
In this case ther eis no reason not to use a function.

> Sorry, as I said, I am new here: how does this work on this project -
> does the submitter have to agree to all reviewer's comments? Can I ask

No, you don't have to agree.  But we also don't have to accept code
that we don't like ;-)

> somebody else to confirm that using a macro in this case in
> inappropriate?

I already did.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The average woman would rather have beauty than brains,  because  the
average man can see better than he can think.