[U-Boot] [PATCH v4 2/2] NS16550: buffer reads

Albert ARIBAUD albert.u.boot at aribaud.net
Sun Oct 16 14:57:36 CEST 2011


Hi Simon,

Le 16/10/2011 07:14, Simon Glass a écrit :
> From: Scott Wood<scottwood at freescale.com>
>
> From: Scott Wood<scottwood at freescale.com>
>
> This improves the performance of U-Boot when accepting rapid input,
> such as pasting a sequence of commands.
>
> Without this patch, on P4080DS I see a maximum of around 5 lines can
> be pasted.  With this patch, it handles around 70 lines before lossage,
> long enough for most things you'd paste.
>
> With it enabled, on ppc it's an extra 396 bytes of image size, and 1056
> bytes of BSS.
>
> ARM note from Simon Glass<sjg at chromium.org>  - ARM code size goes from
> 212 to 484 bytes (extra 272 bytes), BSS to 1056 bytes.
>
> Signed-off-by: Scott Wood<scottwood at freescale.com>
> ---
> Changes in v2:
> - Fix checkpatch warnings, the other one was already there
>
> Changes in v3:
> - Use CONFIG_NS16550_BUFFER_READS to set the buffer size also
>
> Changes in v4:
> - Change config option to CONFIG_NS16550_RBUF_SIZE
> - Add additional checkpatch-cleanup patch

Hmm... What about the conversation around V2 of the patch re: using 
XOFF/XON to control input flow? IIUC, even this V4 patch would not help 
much if there is a command within the pasted code that sends a lot of 
output, right?

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list