[U-Boot] [PATCH v2] NS16550: buffer reads

[Wolfgang Denk]

Dear Simon Glass,

In message <CAPnjgZ0yVMqzyGceUEXiBt6dtsVuqikSPJ_Vw8VU_nb-ST6zJA at mail.gmail.com> you wrote:
> 
> I think this is what said before. In the case of expect, I must put
> the board into the right state, disconnect my terminal from the board,
> run the expect script and re-connect.

You can run it under expect all the time when you are planning to
perform such actions.

> In the case of 2 and 3, they are essentially the same. Both require a
> file transfer to the board (perhaps tftp) which involves editing and
> putting the file somewhere.
> 
> This is not friendly behaviour.

Come on.  It's even more friendly than what you are doing now.

With "env import" you can just use the output from "printenv" on a
working, tested board, copy and paste this into a file, and then
download nd import that (through network or serial download - serial
download is not slower than pasting it over the serial line - just way
more reliable).

For copy and paste, you have to manuallay insert "setenv " in front of
all lines, and add appropriate quoting.

And the BIG benfit is: it just works.

> > If the setenv commands are configuration commands (such as network
> > config, or setting up a new boot path) then they may not already exist
> > in the machine. It is much easier to paste commands from a text editor
> > / notepad than create a script, put it onto the tftp server, tftp the
> > script and run it.
> 
> My point was that they both require putting the file somewhere and
> using the network to get the file.

Put the file somehwere, yes. Some file anywhere on your system.  Not a
big problem, or is it?

Using the network: this is one option; it's the most convenient one if
network is already configured.   Otherwise just use serial download.

> I would agree with this if there were an error message or warning that
> serial input overflow occurred. At the moment it is just confusing or
> buggy.

But your patch is NOT fixing that. It just pushes the limits a bit.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is clear that the individual who persecutes a  man,  his  brother,
because he is not of the same opinion, is a monster.       - Voltaire