[U-Boot] [PATCH 1/2] Add board_panic_no_console to deal with early critical errors

Simon Glass sjg at chromium.org
Mon Oct 17 22:21:52 CEST 2011


Hi Wolfgang,

On Mon, Oct 17, 2011 at 1:06 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Simon Glass,
>
> In message <1314633910-8550-2-git-send-email-sjg at chromium.org> you wrote:
>> Tested-by: Simon Glass <sjg at chromium.org>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>  include/common.h |    8 ++++++++
>>  lib/vsprintf.c   |   26 ++++++++++++++++++++++++--
>>  2 files changed, 32 insertions(+), 2 deletions(-)
>
> Can we please make this feature conditional, so that boards that are
> not going to use it don't have to suffer from the increased code size?
>

We can easily make some of it conditional (the exported functions),
but some of it is changes to make the low-level formatter respect an
'end' pointer. I will take a look as there might be something clever
we can do there. We would also need to add, for example, an snprintf()
macro which drops the numeric parameter, so that code which uses
snprintf() continues to work.

Regards,
Simon

> Thanks.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> "The combination of a number of things to make existence worthwhile."
> "Yes, the philosophy of 'none,' meaning 'all.'"
>        -- Spock and Lincoln, "The Savage Curtain", stardate 5906.4
>


More information about the U-Boot mailing list