[U-Boot] [PATCH v6 04/20] sandbox: Add compiler defines to support a 64-bit x86_64 platform

Wolfgang Denk wd at denx.de
Mon Oct 17 22:59:12 CEST 2011


Dear Simon Glass,

In message <1318270953-32482-5-git-send-email-sjg at chromium.org> you wrote:
> This sets __WORDSIZE to 8 correctly on 64-bit machines.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> Changes in v2:
> - Update commit message to remove 'temporary'
> - Allow __WORDSIZE to be defined in Makefile / elsewhere
> 
>  include/compiler.h |   12 +++++++++++-
>  1 files changed, 11 insertions(+), 1 deletions(-)

This commit breaks building of all (or at least almost all, probbaly
all ARM and PPC) boards:

+ ./MAKEALL ppc
In file included from /home/wd/git/u-boot/work/include/image.h:36,
                 from include/common.h:117:
/home/wd/git/u-boot/work/include/compiler.h:119:2: error: #error "__SIZEOF_LONG__ has unexpected value"
/home/wd/git/u-boot/work/include/compiler.h:128:2: error: #error "__WORDSIZE has unexpected value"
In file included from /home/wd/git/u-boot/work/include/image.h:36,
                 from include/common.h:117:
...

+ ./MAKEALL arm
In file included from /home/wd/git/u-boot/work/include/image.h:36,
                 from include/common.h:117:
/home/wd/git/u-boot/work/include/compiler.h:119:2: error: #error "__SIZEOF_LONG__ has unexpected value"
/home/wd/git/u-boot/work/include/compiler.h:128:2: error: #error "__WORDSIZE has unexpected value"
In file included from /home/wd/git/u-boot/work/include/image.h:36,
                 from include/common.h:117:
...

This happend both when building on i686 and on x86_64 build hosts.

Please fix.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
After a time, you may find that "having" is not so pleasing a thing,
after all, as "wanting."  It is not logical, but it is often true.
	-- Spock, "Amok Time", stardate 3372.7


More information about the U-Boot mailing list