[U-Boot] [PATCH v3] common: fix missing function pointer relocation in fixup_cmdtable()

Daniel Schwierzeck daniel.schwierzeck at googlemail.com
Tue Oct 18 23:12:22 CEST 2011


In commit fa28bd2eef588ec2048ccafedb2b384d5a355858 patch v1 was applied
instead of v2. This is an incremental patch to update that commit
to version 2.

Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck at googlemail.com>
---
changes for v2:
  use correct type cast
  
changes for v3:
  rebased against current master
  incremental patch from v1 to v2

one checkpatch.pl warning:
  WARNING: line over 80 characters
  #38: FILE: common/command.c:483:
  +				(int (*)(int, char * const [], char, int, char * []))addr;

 common/command.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/common/command.c b/common/command.c
index 2c0bf53..c5cecd3 100644
--- a/common/command.c
+++ b/common/command.c
@@ -479,7 +479,8 @@ void fixup_cmdtable(cmd_tbl_t *cmdtp, int size)
 #ifdef CONFIG_AUTO_COMPLETE
 		if (cmdtp->complete) {
 			addr = (ulong)(cmdtp->complete) + gd->reloc_off;
-			cmdtp->complete = (char *)addr;
+			cmdtp->complete =
+				(int (*)(int, char * const [], char, int, char * []))addr;
 		}
 #endif
 		cmdtp++;
-- 
1.7.7



More information about the U-Boot mailing list