[U-Boot] [PATCH v2] tools: checkpatch.pl from Linux added to tools

Joe Hershberger joe.hershberger at gmail.com
Wed Oct 19 20:28:55 CEST 2011


Hi Wolfgang,
On Tue, Oct 18, 2011 at 3:06 PM, Joe Hershberger <joe.hershberger at ni.com> wrote:
> Added from Linux - commit 30ecad51849ae132dc6ef6ddb62d499c7257515b
>
> Include config file to ignore common false-positives
>
> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Joe Hershberger <joe.hershberger at gmail.com>
> Cc: Wolfgang Denk <wd at denx.de>
> ---
> Changes for v2:
>  - Remove exceptions that were needed for CONFIG_ROOTPATH patches
>  - Add exceptions for min/max and simple_strtoul
>
>  .checkpatch.conf    |   15 +
>  tools/checkpatch.pl | 3337 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 3352 insertions(+), 0 deletions(-)
>  create mode 100644 .checkpatch.conf
>  create mode 100755 tools/checkpatch.pl
>
> diff --git a/.checkpatch.conf b/.checkpatch.conf
> new file mode 100644
> index 0000000..52ae3ff
> --- /dev/null
> +++ b/.checkpatch.conf
> @@ -0,0 +1,15 @@
> +# Not Linux, so don't expect a Linux tree.
> +--no-tree
> +
> +# Temporary for false positive in checkpatch
> +--ignore COMPLEX_MACRO
> +
> +# For CONFIG_SYS_I2C_NOPROBES
> +--ignore MULTISTATEMENT_MACRO_USE_DO_WHILE
> +
> +# For simple_strtoul
> +--ignore CONSIDER_KSTRTO
> +
> +# For min/max
> +--ignore MINMAX
> +

Is this list of exceptions reasonable to you?  Should I be looking to
ignore or not ignore anything else?

Thanks,
-Joe


More information about the U-Boot mailing list