[U-Boot] [PATCH 2/3] mpc85xx: Add a board-specific restart hook

[Moffett, Kyle D]

On Oct 18, 2011, at 23:20, Mike Frysinger wrote:
> On Tuesday 18 October 2011 19:41:23 Kyle Moffett wrote:
>> +int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>> +{
>> 	unsigned long val, msr;
>> 
>> +	/* Allow boards to override the reset */
>> +	int err = __board_restart();
>> +	if (err)
>> +		return err;
> 
> i thought we decided that do_reset() shouldn't return
> -mike

For our hardware we have to coordinate reset between both CPUs on the
same physical board, so a "reset" command may hang indefinitely waiting
for the other CPU (IE: If it refuses to shutdown in Linux or is running
U-Boot).

So for user convenience I need to be able to Ctrl-C the communication.
Since "reset" is basically just like any other U-Boot shell command,
(except with some side-effects) it seems reasonable to allow a board
handler to return an error instead of resetting.

Cheers,
Kyle Moffett

--
Curious about my work on the Debian powerpcspe port?
I'm keeping a blog here: http://pureperl.blogspot.com/