[U-Boot] [PATCH 4/4] bootm: Add earlyprintk to fixup_silent_linux

[Doug Anderson]

On Wed, Oct 19, 2011 at 3:35 PM, Mike Frysinger <vapier at gentoo.org> wrote:

> On Wednesday 19 October 2011 18:30:59 Doug Anderson wrote:
> > +     /* Add in earlyprintk */
> > +     original_str = "console=ttyS0,115200n8 root=/dev/mmcblk0p3
> earlyprintk";
> > +     expected_str = "root=/dev/mmcblk0p3 console=";
>
> *choke* wtf just happened here ?
>

Can you clarify what you're asking?

Are you asking about fixup_silent_linux()?  That's a function that already
exists in u-boot.  Its goal is to modify the command line to change the
"console=blah" argument to a "console=", effectively telling Linux not to
have a console.

This particular patchset is extending fixup_silent_linux() to also remove
"earlyprintk" from the command line, since the console isn't really silent
unless you do that.

...or are you asking about the bit of unittest code to test that the
stripping of "earlyprintk" really works?  I was definitely not certain about
whether to add the unittests in here (since there's no way to run them).  My
hope was that at some point in time there'd be a unit test infrastructure in
u-boot and my unit tests could then be incorporated.  If you'd rather not
see the unit tests at all, I'm happy to strip them out.


Maybe a GUI diff showing this change would help?  If so, you can see it
here:
    http://gerrit.chromium.org/gerrit/8822

...that is where I got early reviews of this change before sending it to the
list.


Thanks!

-Doug