[U-Boot] [PATCH 7/7][v2] fsl_ifc: Add the workaround for erratum IFC A-003399(enabled on P1010)

[Aggrwal Poonam-B10812]

> -----Original Message-----
> From: Kumar Gala [mailto:galak at kernel.crashing.org]
> Sent: Wednesday, October 19, 2011 11:52 AM
> To: Aggrwal Poonam-B10812
> Cc: u-boot at lists.denx.de List; Wolfgang Denk
> Subject: Re: [U-Boot] [PATCH 7/7][v2] fsl_ifc: Add the workaround for
> erratum IFC A-003399(enabled on P1010)
> 
> 
> On Oct 18, 2011, at 3:18 PM, Wolfgang Denk wrote:
> 
> > Dear Kumar,
> >
> > In message <C9025279-8F82-453E-8B43-A5D2270A0BCA at kernel.crashing.org>
> you wrote:
> >>
> >> If you look at the code I have NO IDEA how to fix this for older GCC.
> >
> > Maybe you have to explain the code to me. LIke the compiler, I wonder
> > where l2srbar gets initialized:
> >
> > Here is the declaration:
> >
> > ...
> > 74         u32  *l2srbar, *dst, *src;
> > ...
> >
> > First use of this variable is here:
> >
> > ...
> > 139         for (i = 0; i < 1024; i++)
> > 140                 *l2srbar++ = *src++;
> > ...
> >
> > Where is the initialization?
> 
> I apologize, now that I look at this I question what in the world is
> going on.
> 
> Poonam,
> 
> What's going on whit this code:
> 
>         dst = (u32 *) SRAM_BASE_ADDR;
>         src = (u32 *) setup_ifc;
>         for (i = 0; i < 1024; i++)
>                 *l2srbar++ = *src++;
> 
> we don't use 'dst' as far as I can tell and 'l2srbar' is never
> initialized so what in the world are we writing to?
> 
Hello Kumar, Wolfgang

This is a mistake, I admit. 
Extremely sorry for this.
I will send a new patch.

> - k