[U-Boot] [PATCH 3/4] bootm: Avoid 256-byte overflow in fixup_silent_linux()

Wolfgang Denk wd at denx.de
Thu Oct 20 16:40:41 CEST 2011


Dear Doug Anderson,

In message <1319063459-4804-4-git-send-email-dianders at chromium.org> you wrote:
> This makes fixup_silent_linux() use malloc() to allocate its
> working space, meaning that our maximum kernel command line
> should only be limited by malloc().  Previously it was silently
> overflowing the stack.
> 
> Signed-off-by: Doug Anderson <dianders at chromium.org>
> ---
>  common/cmd_bootm.c |  125 ++++++++++++++++++++++++++++++++++++++++++++--------
>  1 files changed, 106 insertions(+), 19 deletions(-)

Code and description have very little to do with each other.  Yoiur
patch contains at least one other, big change.

Please split into separate patches.

Expect that the change to use malloc() will be applied, and the rest
will probably be rejected (see previous message).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The IQ of the group is the lowest IQ of a member of the group divided
by the number of people in the group.


More information about the U-Boot mailing list