[U-Boot] [PATCH 4/4] bootm: Add earlyprintk to fixup_silent_linux

[Wolfgang Denk]

Dear Doug Anderson,

In message <CAD=FV=Ueawx_8Pw8bdni2BPbHP1p-XjsoURmRZr-1QvQ3YXd-A at mail.gmail.com> you wrote:
>
> I'm not sure I understand your comment.  It sounds to me like you're saying
> that fixup_silent_linux() (which already exists in u-boot code) shouldn't be
> needed anymore in u-boot.  ...and maybe you're considering it deprecated?

I consider at least the way how it was done deprecated.

>  Would you like me to submit a patch to remove it?

There are boards that use it.  If you remove it, you must provide some
replacement so these boards don;t break.

> It appears that fixup_silent_linux() was originally added by you in 2003
> (f72da3406bf6f1c1bce9aa03b07d070413a916af).

2003... heh.  By then, life was pretty much unregulated, and you could
get about any code in ;-)

> ...or are you saying that you don't see the need to
> change fixup_silent_linux() to also remove "earlyprintk"?

I think all this code is more or less dead (however I don't know who
might actually actively use or even depend on it).
fixup_silent_linux() was intended to remove only the "console="
argument from the kernel command line, and actually only the firrst of
it if there should be several.  At the time this code was written,
that was only used on PPC, and the 256 byte buffer size was also the
hardwired limit for the cmdline in that time's Linux kernels - so when
written everything was correct (though bound to break as soon as Linux
allows for longer cmdline args).


If you think it would be nice to be able to perform special operations
(like general substitution) on U-Boot environment variables, this
should be written as a separate command that can be run from the
command line, and that can be applied to all variables - not a
hardwired special-cased construct for bootargs only.  We can then make
this command optional, and then we can even remove
fixup_silent_linux() and replace it by calls to that code for the
boards that need it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
CONSUMER NOTICE:  Because  of  the  "Uncertainty  Principle,"  It  Is
Impossible  for  the  Consumer  to  Find  Out  at  the Same Time Both
Precisely Where This Product Is and How Fast It Is Moving.