[U-Boot] [PATCH v2 REPOST 2/3] image: Implement IH_TYPE_KERNEL_REL

Wolfgang Denk wd at denx.de
Thu Oct 20 21:37:07 CEST 2011


Dear Stephen Warren,

In message <74CDBE0F657A3D45AFBB94109FB122FF173D51C255 at HQMAIL01.nvidia.com> you wrote:
>
> Sorry, but why exactly?

Because I'm short of time, and would consider it helpful if you
explain that you mean?

> The patch I posted doesn't add size to the U-Boot binary without the
> configuration option turned on, and I believe should be reviewable and
> hopefully even in a state ready to be replied without any further change
> or explanation.
> 
> Simon Glass questioned whether the change should be allowed to increase
> binary size even when disabled, so as to avoid adding at least some of
> the ifdefs. At present, I'm not going to pursue that since it's obvious
> that's not what you want.

You misunderstand.  I am interested in avoiding #ifdef's, but I'm also
interested in understanding exactly which price we have to pay
instead.

> Please, again, just take a look at the patch itself and ignore this part
> of the thread. I *really* don't think the patch needs any explanation in
> its current form.
> 
> At this point, I'm honestly tempted to just give up on these U-Boot patches.

Me too.


Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Never put off until tomorrow what you can put off indefinitely.


More information about the U-Boot mailing list