[U-Boot] [PATCH] Allow the "reset" command to be omitted with CONFIG_CMD_RESET

[Mike Frysinger]

On Thursday 20 October 2011 16:10:10 Moffett, Kyle D wrote:
> On Oct 20, 2011, at 15:53, Mike Frysinger wrote:
> > On Thursday 20 October 2011 15:05:50 Kyle Moffett wrote:
> >> --- a/common/cmd_boot.c
> >> +++ b/common/cmd_boot.c
> >> @@ -71,8 +71,10 @@ U_BOOT_CMD(
> >> 
> >> #endif
> >> 
> >> +#ifdef CONFIG_CMD_RESET
> >> U_BOOT_CMD(
> >> 
> >> 	reset, 1, 0,	do_reset,
> >> 	"Perform RESET of the CPU",
> >> 	""
> >> 
> >> );
> >> +#endif
> > 
> > would be a good time to split this into a dedicated common/cmd_reset.c
> 
> Is it really worth a separate file for just 7 lines of code?
> 
> The "do_reset" function itself is defined in the architecture-specific
> code that implements it (EG: arch/powerpc/cpu/mpc85xx/cpu.c), so there
> is nothing else generic about the command.

we can also then fix cmd_boot.c to only build when CONFIG_CMD_GO is enabled
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111020/0973fd81/attachment.pgp