[U-Boot] [PATCH 1/4] cmdline: Add linux command line munging tools

[Doug Anderson]

Wolfgang,

On Thu, Oct 20, 2011 at 12:03 PM, Wolfgang Denk <wd at denx.de> wrote:

> > In any case, I already have the more direct (and less generalized)
> version
> > of fixup_silent_linux() written and will send out a patch with just that
> > shortly.
>
> Please consider it NAKed.


One side effect of not committing any patch for fixup_silent_linux() is that
it means that anyone who defines CONFIG_SILENT_CONSOLE and is booting Linux
with "bootm" is subject to the current buffer overrun (regardless of whether
they have a "console=" clause in their Linux command line).

I understand your concerns and will plan to change the way our boot scripts
work so that fixup_silent_linux() isn't needed in our case.  However, since
we still want to define CONFIG_SILENT_CONSOLE we will need something to keep
the buffer overrun away.

If you will not accept a patch to fix the buffer overrun, will you accept a
patch that adds a new config option like CONFIG_DONT_FIXUP_SILENT_LINUX that
prevents fixup_silent_linux() from being called?  That way, any existing
code that relies on the current behavior will continue to work as it does
today, but anyone who wants to avoid the buffer overrun can.

...or, an alternate would be to add CONFIG_FIXUP_SILENT_LINUX to all
existing configs with CONFIG_SILENT_CONSOLE and use that.


Thanks!

-Doug