[U-Boot] [PATCH] Fix compile issue in arch/arm/lib/board.c

[Heiko Schocher]

Hello Marek,

Marek Vasut wrote:
> The commit dc8bbea0170eb2aca428ea221c91fc2e5e11f199 breaks the build of U-Boot
> if CONFIG_CMD_NET is enabled.
> 
> arm: Use getenv_ulong() in place of getenv(), strtoul
> 
> This changes the board code to use the new getenv_ulong() function.
> 
> Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Wolfgang Denk <wd at denx.de>
> Cc: Albert ARIBAUD <albert.u.boot at aribaud.net>
> ---
>  arch/arm/lib/board.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> index c764844..558e973 100644
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
> @@ -566,7 +566,7 @@ void board_init_r(gd_t *id, ulong dest_addr)
>  	/* Initialize from environment */
>  	load_addr = getenv_ulong("loadaddr", 16, load_addr);
>  #if defined(CONFIG_CMD_NET)
> -	s = getenv("bootfile");
> +	char *s = getenv("bootfile");

Did you compiled this? I think, this should generate a compiler warning.

>  	if (s != NULL)
>  		copy_filename(BootFile, s, sizeof(BootFile));
>  #endif

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany