[U-Boot] [RFC] [PATCH 00/39] Rework of the debug() macro

Detlev Zundel dzu at denx.de
Mon Oct 24 12:10:02 CEST 2011


Hi Marek,

[...]

> So because noone actually bothered to compile u-boot with DEBUG enabled, we (me 
> ?) now have literally piles of places to fix. Hm :-(

So it seems.  This is a very good reminder of the fact that with ifdef
we actually hide source code from the compiler under certain
circumstances.  The number of these "certain circumstances" produces the
number of _differing input_ to our compiler.  Given the trivial fact
that a simple ifdef results in two different inputs one needs only to
visualize the graph of 2^x to get an idea of how many sources we are
actually using.

Unrelated to your current efforts (that are greatly appreciated) We
should really try not to use #ifdef at all.  Using constants together
with the dead code eliminatino of the compiler can usually reach the
same goal but with syntax checks on every compile.

Sorry, but I couldn't resist lobbying for this.  Perhaps it helps when
it gets repeated approximately every year ;)

Cheers
  Detlev

-- 
Für jemanden, der in eine Religion geboren wurde, in der das Ringen um eine
einzige Seele ein Stafettenlauf über viele Jahrhunderte sein kann [..], hat
das Tempo des Christentums etwas Schwindelerregendes.   Wenn der Hinduismus
friedlich dahinfließt wie der Ganges,  dann ist das  Christentum Toronto in
der Rushhour.                        -- Yann Martel
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de


More information about the U-Boot mailing list