[U-Boot] [RFC] [PATCH 00/39] Rework of the debug() macro

Marek Vasut marek.vasut at gmail.com
Mon Oct 24 14:33:45 CEST 2011


> Hi Marek,

Hi Detlev,

> 
> [...]
> 
> > I certainly see your point. Btw. do you feel like help reviewing the PPC
> > portion of the patches? That'd be greatly appreciated as I'm not a PPC
> > expert. I wanted to avoid resubmission, so I only pushed the new set to
> > git://git.denx.de/u-boot- marex.git / debug branch. There is over 50
> > patches now.
> 
> I fear that we have the possibility to loose efforts in communicating
> our distrubuted efforts here.  If want to ack only a subset of the
> patches only available on a git tree, I don't know how to give my
> "Acked-By" through the patchwork magic and _not_ add even more work on
> your shoulders.  On the other hand, the majority of fixes are printf
> fixes, so if the compiler does not complain on a MAKEALL any more, I
> don't see what other aspect I can evaluate on a "dry review".

More like a superset actually.

> 
> Effectively I was hoping that your large patch set stabilizes and
> produces no more warnings on a MAKEALL - in this case you have my
> 
> Acked-by: Detlev Zundel <dzu at denx.de>

There are a few patches that are not only printf() format patches. And even 
those printf() format patches deserve proper review.

Cheers


More information about the U-Boot mailing list