[U-Boot] [PATCH] ARM: orion5x: reduce dependence of including platform file

[Wolfgang Denk]

Dear Lei Wen,

In message <1319509652-5648-1-git-send-email-leiwen at marvell.com> you wrote:
> For files like the drivers/serial/serial.c, it must include the
> platform file, as the CONFIG_SYS_NS16550_COM1 must reference to
> the definition in the platform definition files.
> 
> Include the platform definition file in the config file, so that it
> would decouple the dependence for the driver files.
...

> --- a/include/configs/edminiv2.h
> +++ b/include/configs/edminiv2.h
> @@ -45,6 +45,7 @@
>  #define CONFIG_88F5182		1	/* SOC Name */
>  #define CONFIG_MACH_EDMINIV2	1	/* Machine type */
>  
> +#include <asm/arch/orion5x.h>

I don't like this.


Board config files MUST NOT do any such includes.  Keep in mind that
one day we might want to try something like Kconfig, so board config
files should ONLY contain configuration information in the form of
#define's and the like.

NAK.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Wisdom is one of the few things that looks bigger the further away it
is.                               - Terry Pratchett, _Witches Abroad_