[U-Boot] [PATCH v4 2/2] NS16550: buffer reads

Scott Wood scottwood at freescale.com
Tue Oct 25 18:09:35 CEST 2011


On 10/17/2011 07:53 AM, Wolfgang Denk wrote:
> Dear Simon,
> 
> I wrote:
> 
>> - However, your implementation does not result in reliable multi-line
>>   input.  It works only in a few specific use cases, and will fail
>>   silently for others.  I don't see a way ho you would announce this
>>   new feature.  The numbers you mention in the commit message ("it
>>   handles around 70 lines before lossage") apply for this specific
>>   board only, and for your use case only (pasting of short lines that
>>   produce no output).
> 
> Actually I believe that the restriction is even worse - I think that
> any commands that consume any significant amount of time will casue
> problems, too.  Can you please test what happens when you have, for
> example, a "sleep 10" or a "erase all" in the first few lines of the
> pasted input ?

The reference to "70 lines" was meant as an anecdote about how it made
pasting things significantly more usable for me.  I never advertised it
as a complete fix for serial loss (indeed, it even says that I still
experienced loss after 70 lines).  It's just a fairly simple change that
lessens the problem for me (and apparently others) to the point where
it's no longer a significant nuisance.

-Scott



More information about the U-Boot mailing list