[U-Boot] [PATCH v4 08/11] arm, davinci: add lowlevel function for dm365 soc

[Christian Riesch]

Good morning Heiko,

On Monday, October 24, 2011, Heiko Schocher <hs at denx.de> wrote:

[...]

>
>  arch/arm/cpu/arm926ejs/davinci/dm365_lowlevel.c    |  466
++++++++++++++++++++
>  arch/arm/include/asm/arch-davinci/dm365_lowlevel.h |   43 ++
>  2 files changed, 509 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/cpu/arm926ejs/davinci/dm365_lowlevel.c
>  create mode 100644 arch/arm/include/asm/arch-davinci/dm365_lowlevel.h
>
> diff --git a/arch/arm/cpu/arm926ejs/davinci/dm365_lowlevel.c
b/arch/arm/cpu/arm926ejs/davinci/dm365_lowlevel.c
> new file mode 100644
> index 0000000..d7c6a3e
> --- /dev/null
> +++ b/arch/arm/cpu/arm926ejs/davinci/

[...]

> +void dm365_lpc_transition(unsigned char module, unsigned char domain,
> +                               unsigned char state)
> +{

[...]

> +       dm365_lpc_transition(LPSC_DDR2, 0, PSC_ENABLE);

[...]

> +       /* Set the DDR2 to synreset, then enable it again */
> +       dm365_lpc_transition(LPSC_DDR2, 0, PSC_SYNCRESET);
> +       dm365_lpc_transition(LPSC_DDR2, 0, PSC_ENABLE);
> +

dm365.c from the same directory uses lpsc_on(). Could you also use this
function (and lpsc_syncreset from [1]) and remove dm365_lpc_transition
instead?

Regards, Christian

[1] http://patchwork.ozlabs.org/patch/119375/