[U-Boot] [PATCH v2] NS16550: buffer reads

Scott Wood scottwood at freescale.com
Wed Oct 26 20:50:18 CEST 2011


On 10/26/2011 01:17 PM, Wolfgang Denk wrote:
> - Failure to process multi-line input is a restriction, and if you
>   like you may even consider it a bug.

Is this restriction documented anywhere?

>   But papering over that bug and
>   suggesting to the end users that they are allowed to use multi-line
>   input while we all know very well that it actually works only under
>   certain (somewhar fragile) assumptions is a fraudulent misrepresen-
>   tation.

Well then I guess you'd better forcibly dump any input received after a
newline, before the next prompt is displayed -- because the current
U-Boot implementation "fraudulently" made me think such a thing was
possible but resource-constrained when it worked for up to 5 lines for
the particular thing I was trying to paste. :-)

> The approaches discussed so far all have issues. So far I don't see
> an approach that appears to be generally usable, clean in design and
> reliable in operation.

That seems like it would be interrupts, but there's a conflict here
between "solve it perfectly (at least up to the limit of the internal
buffer)" and "this is just a bootloader, keep it simple".  And it seems
there's no room for a pragmatic middle ground.

> Regarding this specific patch you submitted: I made my mind up, and I
> reject it for the resons given above and in previous messages.

Oh well, I guess we'll just maintain it locally, or find some
alternative to pasting things.

-Scott



More information about the U-Boot mailing list