[U-Boot] [PATCH v2 04/11] net: tftpput: Add support for receiving ICMP packets

[Wolfgang Denk]

Dear Simon Glass,

In message <CAPnjgZ11LhBs9W8-GCYYEy2=A1CrCoe-17sz3RK1Q1fPhedL=g at mail.gmail.com> you wrote:
> 
> > /work/wd/tmp-ppc/u-boot.lds:69 cannot move location counter backwards
> > (from 4000815c to 40008000)
> 
> I did see this in my testing, but it seemed to happen even without my
> changes, so I assumed it was just broken. Are you sure it built
> recently? If so please give me a commit hash so I can try it. The last
> one I can find is a year ago 2ae1824. I tried about 6 other commits
> since then and it doesn't always always fail with the same error.

I ran git bisect to detect it.  f75dd58 was a known to be clean commit
before adding your patches.

> The problem seems to be due to these lines in the .lds file for the board:
>
>     net/libnet.o			(.text*)
>     drivers/rtc/librtc.o		(.text*)
>
>     . = env_offset;
>     common/env_embedded.o		(.text*)
>
> The env_offset is probably too small as the net code has increased in
> size by about 600 bytes over the year.

The question is - why does your patch increase the code size?  These
boards do not enable the new tftpput feature, so they should not be
affected.

> There are other things that can be done in net to reduce code size.

I'm not struggeling for each and every byte, but your patches here
should not add code size to any boards that do not enable this new
feature.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When all is said and done, more is said than done.