[U-Boot] [RFC PATCH 1/3] sandbox: gpio: WIP add basic driver for simulating GPIOs

[Mike Frysinger]

On Wed, Oct 26, 2011 at 18:54, Simon Glass wrote:
> --- /dev/null
> +++ b/drivers/gpio/sandbox.c
>
> +#include <asm/io.h>
> +#include <asm/bitops.h>

not used

> +#include <asm/arch/gpio.h>

should be asm/gpio.h

> +/* These functions make up what could be a public interface within U-Boot */

these are the public interface in u-boot.  i wonder why you need the
sandbox_* names at all rather than just the public asm/gpio.h
interfaces.

> +U_BOOT_CMD(
> +       gpio,   5,      1,      do_gpio,

if you implemented the asm/gpio.h interface only, you should be able
to re-use the existing cmd_gpio.c file rather than implementing your
own from scratch.
-mike