[U-Boot] [PATCH v2 5/6] net: Be less picky about decoding the netretry env var

Simon Glass sjg at chromium.org
Thu Oct 27 23:45:13 CEST 2011


Hi Wolfgang,

On Thu, Oct 27, 2011 at 2:40 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Simon Glass,
>
> In message <1319732672-29071-6-git-send-email-sjg at chromium.org> you wrote:
>> This is intended purely as a code size reduction.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>>  README    |    4 ++++
>>  net/net.c |    6 +++---
>>  2 files changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/README b/README
>> index a1910dc..4d9ab77 100644
>> --- a/README
>> +++ b/README
>> @@ -3579,6 +3579,10 @@ List of environment variables (most likely not complete):
>>                 are tried once without success.
>>                 Useful on scripts which control the retry operation
>>                 themselves.
>> +               When unset, or set to "yes", each network operation
>> +               will retry forever. Note that only the first letter
>> +               is significant (any word beginning with y, n, o
>> +               will select the corressponding option).
>
> Sorry, but especially the 'o' scares me.
>
> May I drop this one?

Yes of course, these are just ideas and I agree about the 'o'.

Regards,
Simon

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> "What if" is a trademark of Hewlett Packard, so stop using it in your
> sentences without permission, or risk being sued.
>


More information about the U-Boot mailing list