[U-Boot] [PATCH] e1000: fix bugs from recent commits

Mike Frysinger vapier at gentoo.org
Fri Oct 28 08:28:31 CEST 2011


On Fri, Oct 28, 2011 at 07:49, Wolfgang Denk wrote:
> --- a/drivers/net/e1000.h
> +++ b/drivers/net/e1000.h
>
>  #define E1000_WRITE_FLUSH(a) \
> -       do { uint32_t x = E1000_READ_REG(a, STATUS); } while (0)
> +       E1000_READ_REG(a, STATUS)

i think we want the do{}while as this is a write command and we don't
want people accidentally trying to check the return value
-mike


More information about the U-Boot mailing list