[U-Boot] [PATCH] ARM: netspace_v2: fix warnings

Simon Guinot simon at sequanux.org
Sun Oct 30 13:40:21 CET 2011


On Sat, Oct 29, 2011 at 11:31:19PM +0200, Anatolij Gustschin wrote:
> Fix compiler warnings when compiling for netspace_v2, netspace_max_v2
> and inetspace_v2:
> 
> netspace_v2.c: In function 'board_early_init_f':
> netspace_v2.c:37: warning: implicit declaration of function 'kw_config_gpio'
> netspace_v2.c: In function 'board_init':
> netspace_v2.c:86: warning: implicit declaration of function 'kw_sdram_bar'

It seems to me this regression has been introduced by:

commit a7efd719f415833a833d6a8e46bcd470a0847ecc
Author: Lei Wen <[leiwen at marvell.com]>
Date:   Tue Oct 18 20:11:42 2011 +0530

    ARM: kirkwood: reduce dependence of including platform file
    
    For files like the drivers/serial/serial.c, it must include the
    platform file, as the CONFIG_SYS_NS16550_COM1 must reference to the
    definition in the platform definition files.
    
    Include the platform definition file in the config file, so that it
    would decouple the dependence for the driver files.
    
    Signed-off-by: Lei Wen <leiwen at marvell.com>

Maybe that more boards are affected.

> 
> Signed-off-by: Anatolij Gustschin <agust at denx.de>
> Cc: Simon Guinot <simon.guinot at sequanux.org>
> Cc: Albert ARIBAUD <albert.u.boot at aribaud.net>
> ---
>  board/LaCie/netspace_v2/netspace_v2.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/board/LaCie/netspace_v2/netspace_v2.c b/board/LaCie/netspace_v2/netspace_v2.c
> index 3bb83f3..7c4b15e 100644
> --- a/board/LaCie/netspace_v2/netspace_v2.c
> +++ b/board/LaCie/netspace_v2/netspace_v2.c
> @@ -24,6 +24,7 @@
>  #include <miiphy.h>
>  #include <netdev.h>
>  #include <command.h>
> +#include <asm/arch/cpu.h>
>  #include <asm/arch/kirkwood.h>
>  #include <asm/arch/mpp.h>
>  #include <asm/arch/gpio.h>

Acked-by: Simon Guinot <simon.guinot at sequanux.org>

Thanks for the compilation clean-up.

Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111030/e6aaa9cc/attachment.pgp 


More information about the U-Boot mailing list