[U-Boot] [PATCH 1/2] post/post.c: CodingStyle cleanup
Marek Vasut
marek.vasut at gmail.com
Sun Oct 30 21:12:53 CET 2011
> Dear Marek Vasut,
>
> In message <201110300038.14360.marek.vasut at gmail.com> you wrote:
> > > Signed-off-by: Wolfgang Denk <wd at denx.de>
> > > ---
> > >
> > > post/post.c | 59
> > >
> > > +++++++++++++++++++++++++++-------------------------------- 1 files
> > > changed, 27 insertions(+), 32 deletions(-)
> >
> > [...]
> >
> > > if (test->cmd) {
> > >
> > > - addr = (ulong) (test->cmd) + gd->reloc_off;
> > > + addr = (ulong)(test->cmd) + gd->reloc_off;
> > >
> > > test->cmd = (char *)addr;
> > >
> > > }
> > >
> > > if (test->desc) {
> > >
> > > - addr = (ulong) (test->desc) + gd->reloc_off;
> > > + addr = (ulong)(test->desc) + gd->reloc_off;
> > >
> > > test->desc = (char *)addr;
> > >
> > > }
> > >
> > > if (test->test) {
> > >
> > > - addr = (ulong) (test->test) + gd->reloc_off;
> > > + addr = (ulong)(test->test) + gd->reloc_off;
> > >
> > > test->test = (int (*)(int flags)) addr;
> > >
> > > }
> > >
> > > if (test->init_f) {
> > >
> > > - addr = (ulong) (test->init_f) + gd->reloc_off;
> > > + addr = (ulong)(test->init_f) + gd->reloc_off;
> > >
> > > test->init_f = (int (*)(void)) addr;
> > >
> > > }
> > >
> > > if (test->reloc) {
> > >
> > > - addr = (ulong) (test->reloc) + gd->reloc_off;
> > > + addr = (ulong)(test->reloc) + gd->reloc_off;
> >
> > The cast here doesn't seem right maybe ? :-(
>
> Why not?
>
> BTW: this is only a CodingStyle cleanup without any changes of the
> logic.
>
> Best regards,
>
> Wolfgang Denk
Ok! Add my:
Acked-by: Marek Vasut <marek.vasut at gmail.com>
More information about the U-Boot
mailing list